#18941: Poset documentation polishing: chains and antichains
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Kevin Dilks
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset_polishing_chains|  93f35e5dd1f134f072a84f8d08971207d64d8023
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jmantysalo):

 Replying to [comment:36 kdilks]:
 > All the changes you made look good to me, positive review.

 Thanks!

 > Two comments related to things I saw while looking through the code
 (which should probably go in separate tickets):
 >
 > 1) Somebody should finally implement the wrapper that gives you all
 antichains of a specified size.

 True. Same applies to chains of specified size.

 > 2) In {{{is_chain_of_poset}}}, I think there should be an additional
 optional parameter {{{strict}}}, so that when {{{ordered=True}}}, you can
 test whether a given list of elements is a weakly increasing chain or a
 strictly increasing chain. Right now it only tests for strict chains.

 ?? Isn't it just another way? Name of the parameter should propably be
 `saturated`.

--
Ticket URL: <http://trac.sagemath.org/ticket/18941#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to