#19042: Fallback SAT solver in Sage
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jeroen Demeyer
numerical | Work issues:
Keywords: | Commit:
Authors: | 94166b67c1a2e0a06770b7e7fb6acffd71d480f6
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/19042 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
> 1. It's ugly that your ILP solver returns values as `0.0` and `1.0`. It
should be converted to `True`/`False`.
Right.
> 2. `Its performances` -> `Its performance`
Done.
> 3. `cryptominisat_available = True` -> `solver = 'cryptominisat'` and
`cryptominisat_available = False` -> `solver = 'LP'`. That's a lot
cleaner: you can remove the `solver is None` checks.
I'm an idiot.
> 4. Please fix the `deicison` typo also in
`src/sage/sat/converters/polybori.py`
Done.
--
Ticket URL: <http://trac.sagemath.org/ticket/19042#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
