#6452: Submodules of (ZZ/nZZ)^r
-------------------------+-------------------------------------------------
Reporter: wdj | Owner: rlm
Type: | Status: needs_review
enhancement | Milestone: sage-6.10
Priority: major | Resolution:
Component: | Merged in:
linear algebra | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Vincent Delecroix | ffbd6e833d08b51cf78c46065ac07f71f46d795d
Report Upstream: N/A | Stopgaps:
Branch: |
u/vdelecroix/6452 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by jsrn):
Great work Vincent!
Just to be sure: is this "In review"? You made many changes but didn't
change the state of "needs review".
I will look at it in detail later, and when I'm sure it's ready. But in
any case, some preliminary remarks:
- Could you explain to me (reviewer) the reason for the patch in the
category
files? Something with you using the `Facade` in a previously unthought
case.
Is this related to the `Free`-thing below?
- `FreeModule_ambient_IntegerModRing.span` never uses its `check`
argument.
- Since you compute the smith form at construction, then construction is
expensive even when nothing is asked of the object afterwards. Is the
argument for this that nothing interesting can be said about the module
without computing the smith form anyway? Generally, I like construction to
be cheap and postponing computation till the user asks it.
Generally, it looks pretty good though.
--
Ticket URL: <http://trac.sagemath.org/ticket/6452#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
