#19322: a much faster longest_common_prefix for words
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19322 | ebbc28d6aa6e890312fa23f87863ec4179bf6f4b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Yoooooooooo !
> I implemented your remarks excepted 4. It does allocate memory to call
`_new_c`: the one you need for a Python object. But I don't know whether
it is justified or not (ie the ratio between "simple code" versus
"efficient code").
Okay okay, you decide, just felt like bringing it up when I reviewed this
code.
Stamped, and good to go.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19322#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
