#18937: Upgrade patchbot again
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  patchbot           |    Reviewers:  Jeroen Demeyer,
        Authors:  Frédéric Chapoton  |  Nathann Cohen, Vincent Delecroix
Report Upstream:  N/A                |  Work issues:
         Branch:  u/chapoton/18937   |       Commit:
   Dependencies:                     |  10aedb7e47ce3466bd80ca6ed7724df263e706ee
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Indeed `urllib2.URLError` is more general than `urllib2.HTTPError`...
 {{{
 sage: import urllib2
 sage: issubclass(urllib2.URLError, urllib2.HTTPError)
 False
 sage: issubclass(urllib2.HTTPError, urllib2.URLError)
 True
 }}}
 But only `urllib2.HTTPError` is catch at line `1024` of `patchbot.py`.
 Maybe it should be changed?

--
Ticket URL: <http://trac.sagemath.org/ticket/18937#comment:138>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to