#19332: Add discrete_complementarity_set() method for cones
-------------------------------------+-------------------------------------
Reporter: mjo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Michael Orlitzky | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mjo/ticket/19332 | 872932952e7db998d013637636ca82124ace544e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by novoselt):
List is mutable, tuple is not, that the only difference I am aware off
between the two. So if you cache the result, it is better be a tuple (with
all rays made immutable), not a list. Otherwise things still may work, but
when something modifies your cache you'll get hard to debug bugs.
I also doubt there is much point in optimizing this implementation any
further - after all you don't want just to get this set as fast as
possible, you want to also do something interesting with it. But if `+` is
better than `extend` here of course we can use it.
By the way, when benchmarking, take into account that face lattice, faces,
facet normals - everything is cached and so will not be seen in any
timings that run multiple times or one after another on the same object.
The best way of getting "scratch timing" I could come up with in such
situations is to write a function that constructs a new cone and calls new
methods, then time calls to this function.
--
Ticket URL: <http://trac.sagemath.org/ticket/19332#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
