#6936: [with patch, positive review] Implement generic testing from #6343 for
matrices
-------------------------------+--------------------------------------------
Reporter: jason | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: linear algebra | Keywords: TestSuite
Reviewer: Nicolas M. Thiéry | Author: Jason Grout
Merged: |
-------------------------------+--------------------------------------------
Old description:
> The patch calls TestSuite().run() every time load(dumps()) is called in
> the matrix directory. I also added a _test_minpoly() function, and fixed
> an existing _test_pickle() function.
>
> Running doctests in matrix/*.pyx now fails for a number of files. In
> other words, this testing infrastructure works and is uncovering bugs!
>
> The bugs should be dealt with on other tickets.
New description:
The patch calls TestSuite().run() every time load(dumps()) was called in
the matrix directory. I also added a _test_minpoly() function, and
renamed and adapted an existing _test_pickle() into _test_reduce().
Running doctests in matrix/*.pyx now fails for a number of files. In
other words, this testing infrastructure works and is uncovering bugs!
The bugs should be dealt with on other tickets.
--
Comment(by nthiery):
> The -review.patch patch does this.
Thanks!
> The rest of these items sound controversial enough that they should be
brought up on sage-devel.
Do you mind doing it?
> If you're happy with the changes, can you mark this positive review?
Done! However, please someone run the tests. I don't have a sage devel
under hand.
> I'd say merge this, since it uncovers existing bugs, but doesn't
introduce any. With this merged, those bugs will get fixed before the
next release.
Sounds good to me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6936#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
