#18514: Upgrade of group cohomology spkg
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.8
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  group cohomology   |    Reviewers:
        Authors:  Simon King         |  Work issues:  Create a new-style
Report Upstream:  None of the above  |  package with least effort
  - read trac for reasoning.         |       Commit:
         Branch:                     |  499dfbd2a4a25d3ab2f089d36e0d592ba6a0d99e
  u/SimonKing/upgrade_of_group_cohomology_spkg|     Stopgaps:
   Dependencies:  #12103             |
-------------------------------------+-------------------------------------

Comment (by SimonKing):

 Replying to [comment:113 vbraun]:
 > Always prefer shared libraries over static libraries

 OK.

 > With libtool the Makefile.am should contain
 > {{{
 > lib_LTLIBRARIES = libmodres.la
 > libmodres_la_SOURCES = aufloesung.c aufnahme.c fileplus.c nBuchberger.c
 pgroup.c pincl.c slice.c urbild.c
 > }}}

 So, the difference is that it is lib_LTLIBRARIES, not lib_LTLIBRARIES, and
 that the file name extension is .la, not .a.

 What about -fPIC? Well, I will see if it is still needed.

 > Are the upstream meataxe filenames already in German?

 Don't mix the two things `;-)`

 - Meataxe is at #12103, the filenames are English, I only added one file
 window.c (thus, English as well), and I will *not* do upstream's job of
 autotoolisation.
 - Here is modular_resolution, which was originally written by a native
 English speaker in Wuppertal, and he chose the filenames. By rebasing it
 on top of the new meataxe and by using autotools, I became part of
 upstream, but I didn't change the filenames.

 After all, !SageMath is an international project...

 By the way, I am really glad that you guys convinced me of using
 autotools. It really is so much easier!

--
Ticket URL: <http://trac.sagemath.org/ticket/18514#comment:114>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to