#6950: [with patch, needs review] computing algebraic immunity
--------------------------+-------------------------------------------------
 Reporter:  ylchapuy      |       Owner:  somebody          
     Type:  enhancement   |      Status:  new               
 Priority:  minor         |   Milestone:  sage-4.1.2        
Component:  cryptography  |    Keywords:                    
 Reviewer:                |      Author:  Yann Laigle-Chapuy
   Merged:                |  
--------------------------+-------------------------------------------------

Comment(by malb):

 '''Review'''

  * patch applies cleanly against alpha1
  * you shouldn't need {{{#random}}} in the doctest because the random seed
 should be reset before each doctest to make sure that the result is
 reproducible.
  * there are some very minor line break problems in the HTML reference
 manual:
 
http://sage.math.washington.edu/home/malb/scratch/sage-4.1.2.alpha1/devel/sage/doc/output/html/en/reference/sage/crypto/boolean_function.html
  * also {{{..math::}}} is not properly typesetted (cf. same link)
  * doctests pass on sage.math

 So almost positive review, module the nitpicks above. Feel free to change
 it to a positive review once those are addressed.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6950#comment:5>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to