#19385: Refactor DiGraph.__init__
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Travis Scrimshaw
theory | Work issues:
Keywords: | Commit:
Authors: | 99c8601b947b746cfd0cbbca4c836b82b3ac5dde
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/19385 |
Dependencies: |
#19381 |
-------------------------+-------------------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
This LGTM except for this change:
{{{#!diff
- sage: G = DiGraph(M,sparse=True); G
+ sage: G = DiGraph(M,sparse=True,weighted=True); G
}}}
I'm worried that this change of behavior of how you handle weighted graphs
could break other people's code. Unfortunately I can't comment on the
correctness of either behavior, but it might have been a "feature" that
others were using.
--
Ticket URL: <http://trac.sagemath.org/ticket/19385#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
