#6102: cohomology ring of simplicial complexes
-------------------------------------+-------------------------------------
Reporter: bantieau | Owner: bantieau
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers: Travis Scrimshaw
Authors: John Palmieri | Work issues:
Report Upstream: N/A | Commit:
Branch: u/tscrim/AT-model | 716469ac9519fc492467d4a635c80468880df94d
Dependencies: #19179 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
* branch: u/jhpalmieri/AT-model => u/tscrim/AT-model
* commit: 0d2ea83c0d4a66ff254e9382376b04f90d921964 =>
716469ac9519fc492467d4a635c80468880df94d
Comment:
I made some reviewer changes, and it's mostly tweaking docstrings and
copying your sparse/dense hack to get another ~20% in the "new" version.
Ffrom taking a closer look at things, I bet we could get further speedups
by not taking the transpose of the `phi_old` and `pi_old` matrices in the
inner loops and using `v * M` multiplication instead of `M' * v`. I tried
to do this, but I don't think I understand the interworkings of the code
to get this to work (at least for the "new" version). Have you tried to do
this?
Also I noticed that `HomologyVectorSpaceWithBasis` represents a graded
piece of the (co)homology space. Would you be opposed to me rewriting that
such that it becomes the full (co)homology space/ring? I think it would
simplify the overall code structure, allow easier extensions to infinite
simplicial/cell complexes, and give a better interpretation of
`cup_product` as being the product in the cohomology ring. (Also with
#18175, we could then give work towards a cap product for manifolds.)
If you would prefer one/both of these things to be pushed to later
tickets, we can do that, but I'd rather get the latter done now.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=a0f20c2d4dd1a810ff662ba43fb49314c4f4b274
a0f20c2]||{{{Merge branch 'u/jhpalmieri/AT-model' of
trac.sagemath.org:sage into u/jhpalmieri/AT-model}}}||
||[http://git.sagemath.org/sage.git/commit/?id=716469ac9519fc492467d4a635c80468880df94d
716469a]||{{{Some smaller reviewer tweaks.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/6102#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
