#19390: Update the documentation of Graph/DiGraph constructors
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.10
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  4bc51d480bf228cf1bfbcaf25dc2737374a9c7e0
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/ncohen/19390         |
   Dependencies:         |
  #19385                 |
-------------------------+-------------------------------------------------

Comment (by borassi):

 Hellooooooo!

 Sorry if I am not very active in these tickets, but I'm quite busy in
 these days...

 Just to say that when I inserted `igraph`, the variable `vertex_labels`
 was already there, and I only used it in my code. Indeed, you can find
 examples (written before igraph) where this variable was used (for
 instance, in `cliques_get_max_clique_graph`).

 Though, I have no idea what it was used for! The comment in the code
 before my modifications was:

 {{{
     -  ``vertex_labels`` - only for implementation == 'c_graph'.
        Whether to allow any object as a vertex (slower), or
        only the integers 0, ..., n-1, where n is the number of vertices.
 }}}
 Hope this helps!

 Michele

 > > - `only the integers 0, ..., n-1, where n is the number of vertices.`
 math mode around 0, ..., n-1 and n ?
 > >
 >
 > Done, though I will do something about this parameter because it does
 not make any sense. It was apparently added during the igraph tickets, but
 its name (`vertex_labels`) does not hint *at all* at igraph. The doc does
 not either. People could wonder about its effect with every other possible
 combinations of inputs, and it only appears in the code because of igraph.
 So I think we should remove it quick and deal with the igraph case
 otherwise.
 >
 > Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19390#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to