#19392: Add tetrahedral poset code
-------------------------+-------------------------------------------------
Reporter: | Owner:
cvorland | Status: needs_review
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Kevin Dilks
combinatorics | Work issues:
Keywords: | Commit:
Authors: Corey | 890d542c0b16ac87ffb0ea6abe43c16ccd4fbece
Vorland | Stopgaps:
Report Upstream: N/A |
Branch: |
u/cvorland/19392 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by kdilks):
* This needs some tests, and maybe one more example. Examples can be a
good way to illustrate an interesting feature of tetrahedral posets, and
you can also show how it reduces to perhaps more well-known posets for
certain parameters. Also, the code should throw an error if the rest of
the input includes something other than one of the six strings.
* First line of doc should be a single sentence. So I would make the first
line be "Returns the tetrahedral poset based on the input colors.", then
have a slightly more detailed explanation in a second paragraph with the
reference.
* {{{edge_colors}}} is currently superfluous. Though maybe posets should
have an option similar to {{{element_labels}}} where you can assign labels
to the covering relations of your poset. It would be useful here, and
necessary if anybody ever wanted to try and implement EL-labellings.
* I would change the last two lines to just {{{return
Poset([elem,rels],cover_relations=True)}}}.
--
Ticket URL: <http://trac.sagemath.org/ticket/19392#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
