#18109: Restructure IntegerListLex code
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/refactor_integer_lists_lex-18109|
2e5e9691da0c2003d7eb3ddcf6c5c5010281f4dc
Dependencies: #15525 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
* dependencies: => #15525
* branch: u/jdemeyer/ticket/18109 =>
u/tscrim/refactor_integer_lists_lex-18109
* commit: 6fcd10a8384e07df3d3302e9ae1e7c6f6f99217e =>
2e5e9691da0c2003d7eb3ddcf6c5c5010281f4dc
Comment:
I made some doc tweaks while we are moving everything around. Everything
works and since we aren't actually changing the functionality, I'm not
looking at that closely. In short, it looks goods.
In writing this comment, I've convinced myself that having a frontend
class for each backend will likely be a good thing in practice as it can
be used to distinguish different iteration orders without having to look
at the backend (which may not be python visible at the end of the day). It
also makes it easier to define string representations and natural
extensions to subclasses.
In particular, #15525, which we will probably need to tweak some of those
changes to support this new framework (and at least correct the imports,
which is why I listed it as a dependency).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=2e5e9691da0c2003d7eb3ddcf6c5c5010281f4dc
2e5e969]||{{{Some minor reviewer tweaks and doc changes.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18109#comment:85>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
