#19395: Implement Tableau to sign matrix code
-------------------------+-------------------------------------------------
Reporter: | Owner:
ssolhjem | Status: needs_work
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Kevin Dilks
combinatorics | Work issues:
Keywords: | Commit:
Tableau | 5b006a1b94be67ac56c96921ee7c68df37d31495
Authors: Sara | Stopgaps:
Solhjem |
Report Upstream: N/A |
Branch: |
u/ssolhjem/19395 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by tscrim):
Replying to [comment:3 kdilks]:
> In terms of the code:
> * I wouldn't use sparse matrices. Your code goes through defines what
the {{{partial_sum_matrix}}} and {{{sign_matrix}}} is at every single
entry, so you're not taking advantage of the structure of sparse matrices.
In fact, I picked a random SSYT of shape {{{[1000,999,998,...,2,1]}}} with
{{{max_entry=10000}}}, and using sparse matrices was 4 times slower than
not using sparse matrices.
Just to expand on this a little bit, the way Sage creates sparse matrices
is fairly bad. So just remove the `sparse=True` part from the
`MatrixSpace` line.
You should also make sure that `self` is the name of the first argument to
any method. This is a python convention that is very strictly followed.
--
Ticket URL: <http://trac.sagemath.org/ticket/19395#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
