#18066: Cleanup of ModulesWithBasis and friends
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/categories/cleanup_CFM_modules_wBasis-18066|
954e3542ccc00ef3cc294f19019da3608d87a5a8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:3 darij]:
> One more thing, which is probably not your fault but just caught my
eyes. The docstring of `module_morphism` says:
> {{{
> - ``matrix`` -- a matrix of size `\dim X \times \dim Y`
> or `\dim Y \times \dim X`
> }}}
> I don't see why the "or" is here. The doctests show that `\dim Y \times
\dim X` works, but does `\dim X \times \dim Y` work too? And if so,
*should* it? I think checking whether the matrix has the "wrong"
dimensions, and then trying to fix them by transposing it, would be a
brittle paradigm.
Which of the two it is depends on the value of the optional ``side``
argument. No worry, there is no attempt at "fixing" things by
transposition.
--
Ticket URL: <http://trac.sagemath.org/ticket/18066#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
