#19083: AsymptoticRing: cleanup, some improvements, documentation
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: | Reviewers: Clemens Heuberger
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: | a047f66131002494e5c7d42c1363122f50b769bb
u/cheuberg/asy/prototype | Stopgaps:
Dependencies: #19094 |
-------------------------------------+-------------------------------------
Comment (by cheuberg):
Here are my comments on
`src/sage/rings/asymptotic/growth_group_cartesian.py`:
15. `GenericProduct._create_element_via_parent_`:
- see comment 8.
- Error "Cannot create ... as a cartesian product like ..." not
tested.
16. `GenericProduct.Element.__pow__`: "This can be anything that is a
valid right hand side of `*` with elements of the parent's base." seems to
be misplaced (each factor does have a base, and this only applies to
monomial factors).
17. `GenericProduct.Element.__rpow__`: see comment 7.
18. `GenericProduct.Element._rpow_element_`: I think that the loop `for
factor in factors` combined with `continue` makes this more difficult to
read than simply saying `factor = factors[0]` because the length of
`factors` is `1` anyway.
--
Ticket URL: <http://trac.sagemath.org/ticket/19083#comment:62>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
