#17261: Coercions from the modular group to the Theta subgroup
-------------------------------------+-------------------------------------
Reporter: jj | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.10
Component: modular forms | Resolution:
Keywords: hecke triangle | Merged in:
group coercion | Reviewers: Julien Puydt
Authors: Jonas Jermann | Work issues:
Report Upstream: N/A | Commit:
Branch: | b9b0d9d4ab042145574e1f14586f6f24a551c63d
public/ticket/17261 | Stopgaps:
Dependencies: #16976 |
-------------------------------------+-------------------------------------
Changes (by chapoton):
* milestone: sage-6.9 => sage-6.10
Comment:
In this kind of thing (appearing at least twice in your code):
{{{
+ num1 = el_f.numerator().subs( x=(y**2 + 3*x)/ZZ(4),
y=(9*x*y - y**3)/ZZ(8), z=(3*z - y)/ZZ(2)).numerator()
+ num2 = el_f.denominator().subs( x=(y**2 + 3*x)/ZZ(4),
y=(9*x*y - y**3)/ZZ(8), z=(3*z - y)/ZZ(2)).denominator()
+ denom1 = el_f.denominator().subs( x=(y**2 + 3*x)/ZZ(4),
y=(9*x*y - y**3)/ZZ(8), z=(3*z - y)/ZZ(2)).numerator()
+ denom2 = el_f.numerator().subs( x=(y**2 + 3*x)/ZZ(4),
y=(9*x*y - y**3)/ZZ(8), z=(3*z - y)/ZZ(2)).denominator()
}}}
it is possible to substitute only twice. Please do so.
Could you also please remove the following imports (if possible):
{{{
src/sage/modular/modform_hecketriangle/abstract_ring.py:21: 'bernoulli'
imported but unused
src/sage/modular/modform_hecketriangle/abstract_ring.py:21: 'sigma'
imported but unused
src/sage/modular/modform_hecketriangle/abstract_ring.py:26:
'HeckeTriangleGroup' imported but unused
src/sage/modular/modform_hecketriangle/abstract_ring.py:27:
'rational_type' imported but unused
}}}
After that, and once the bot has given a green light again, I will agree
to set a positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/17261#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
