#6102: cohomology ring of simplicial complexes
-------------------------------------+-------------------------------------
Reporter: bantieau | Owner: bantieau
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers: Travis Scrimshaw
Authors: John Palmieri | Work issues:
Report Upstream: N/A | Commit:
Branch: u/jhpalmieri/AT- | 9bfc2d2881810588de6eb1ad85870a7ac95a1b28
model | Stopgaps:
Dependencies: #19179 |
-------------------------------------+-------------------------------------
Changes (by jhpalmieri):
* commit: 37517531687fffbe421b2d882e3073dcb13144e1 =>
9bfc2d2881810588de6eb1ad85870a7ac95a1b28
Comment:
Okay, your turn again. If you're happy with these changes, set it to
positive review. A summary of my changes:
- various documentation fixes: some docstrings didn't get changed in your
refactoring, some cross-references didn't work, etc.
- I moved several instances of `if base_ring is None` to the methods in
`cell_complex.py`. Before, some were there but some were in
`algebraic_topological_model.py`.
- I removed the explicit check about immutability for simplicial complexes
because it wasn't being used: once we cache the method, immutability is
checked as soon as the method is called, so checking again in the method
is redundant. (And if we ever decide that the method should not be cached,
there is no reason to check immutability.)
--
Ticket URL: <http://trac.sagemath.org/ticket/6102#comment:47>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
