#19083: AsymptoticRing: exp & log, cleanup, some improvements, documentation
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: | Reviewers: Daniel Krenn, Clemens
Authors: Benjamin Hackl, | Heuberger
Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: | 80068372f79a2e804be5c864b51bac9a1c75498a
u/dkrenn/asy/prototype | Stopgaps:
Dependencies: #19073 |
-------------------------------------+-------------------------------------
Comment (by dkrenn):
Replying to [comment:66 cheuberg]:
> 36. `AsymptoticExpansion.rpow`:
> - Decrease indentation of ALGORITHM block
Done.
> - Test error "Cannot construct the power ..."
Added test.
> 37. `AsymptoticRing`: Add some comment on the "TESTS" section which is
currently inactive.
Added (#19424).
> 38. `AsymptoticRing.change_parameter`: is this a good name (the method
sounds like an inplace change, but usually returns a new parent instead)
True, but consistent with
{{{
sage: R.<z> = ZZ[]
sage: R.change_ring(QQ)
Univariate Polynomial Ring in z over Rational Field
sage: R
Univariate Polynomial Ring in z over Integer Ring
}}}
> 39. `AsymptoticRing._create_element_via_parent_`:
> - I do not like the name and the description of the method.
Changed earlier already.
> - The role of `old_parent` is not documented
Extended doc.
> - In all uses of the method in this module, `old_parent` is set
and is a term monoid. In the example of this method, it is an asymptotic
ring.
Uuups...changed.
> - I do not understand why `old_parent` is needed: if
`term.parent() is old_parent`, then `self.change_parameter` will probably
not change the parent anyway.
E.g. when inverting, then the `term` parameter will be the already
inverted term and `old_parent` the parent of the original term.
> 40. `AsymptoticRing._element_constructor_`:
> - The note box seems to be outdated, as the parameter `summands`
no longer exists.
Deleted.
> - test error "Not all list entries ..."
> - test error "Symbolic expression ... is not in ..."
Added.
> - Why `not data or data == 0` instead of `not data`?
Changed.
> - What happens with an O-Term in SR?
There seems to be a bug in SR: #19425. Opened follow up #19426.
> - conversion of multivariate polynomial ring is not tested.
Now it is.
> 43. Delete the following in `src/doc/en/reference/rings/index.rst`
> {{{
> .. toctree::
> :hidden:
>
> asymptotic_expansions_index
> }}}
Not possible, since in `src/doc/en/reference/index.rst` all indices are
included
via `:doc:` which seems not to add them to any toctree.
--
Ticket URL: <http://trac.sagemath.org/ticket/19083#comment:90>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
