#6823: [with patch, needs work] Kneser Graph in graph_generators
--------------------------+-------------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.2
Component: graph theory | Keywords: graph generators kneser
Reviewer: | Author:
Merged: |
--------------------------+-------------------------------------------------
Changes (by rbeezer):
* keywords: => graph generators kneser
Comment:
Hi Nathann,
This will be a nice addition to the graph generators. Some suggestions:
1. How about giving the graph a name with the parameters in the string,
like "Kneser graph with parameters 5 and 2"?
2. The patch just seems to be a diff file, so it really should be a
Mercurial patch with your name/email and a one-line comment. Patch files
now seem to uniformly have filenames that begin with "trac_xxxx_" and you
should put the trac number in the one-line summary of the Mercurial patch.
3. I'd really like to see more robust handling of the inputs (and
doctests to see that they work). For example, a negative n will bomb in
the subset code. How about checking that {{{n >= 0}}} and then that {{{0
<= k <= n}}}?
4. English is very good, but I'd suggest "adjacent" or "joined" instead
of "linked" and "with parameters" instead of "of parameters" (three
places).
With this completed, it'll be easy to add the Odd graphs - just Kneser
graphs with n=2k+1.
This passes all tests in sage/graphs and the documentation builds fine.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6823#comment:1>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
