#19399: let category of growth group be determined by input
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.10
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/dkrenn/t/19399   |  4626cc13efc233cd0545b253815babbf3df5ecec
   Dependencies:  #19083             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * commit:  997380baa67cc3d7fda5e9791c29d58f3ff15515 =>
     4626cc13efc233cd0545b253815babbf3df5ecec


Comment:

 Replying to [comment:15 cheuberg]:
 > I added one reviewer commits and have two more remarks.

 Cross-reviewed.

 > 1. `sage.rings.asymptotic.misc.transform_category`: document parameter
 `initial_category`

 Documented.

 > 2. `GenericGrowthElement.__classcall__`: does it make sense to promote
 polynomials to Posets? How is the partial order defined on polynomials?

 The default order is `degrevlex`, see
 
http://doc.sagemath.org/html/en/reference/polynomial_rings/sage/rings/polynomial/polynomial_ring_constructor.html#sage.rings.polynomial.polynomial_ring_constructor.PolynomialRing

 Thus, polynomial rings should be posets as well.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=4626cc13efc233cd0545b253815babbf3df5ecec
 4626cc1]||{{{document initial_category}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19399#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to