#6829: [with patch, positive review] Implement Manin symbols over number fields
---------------------------+------------------------------------------------
Reporter: cremona | Owner: craigcitro
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.2
Component: modular forms | Keywords: modular manin symbols
Reviewer: | Author:
Merged: |
---------------------------+------------------------------------------------
Comment(by GeorgSWeber):
Just my two cents.
Mathematically: Both the normalization (lines 415 - 455) and the list
creation (lines 993 - 1018) look good to me, forming the heart of the
module. Index-looking up is done by list searching, well. The other
internal functions lift_to_sl2_Ok, make_coprime, psi also look good.
Non-mathematically: This is how more Sage library code should look like.
If this applies cleanly to the newest Sage alpha, doctests all pass and
have 100% coverage, and the ReST documentation compiles OK (I didn't
check, but I'd be surprised if there was any issue), then I'd vote to let
this in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6829#comment:3>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
