#18066: Cleanup of ModulesWithBasis and friends
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.10
      Component:  categories         |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:  Darij Grinberg
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/categories/cleanup_CFM_modules_wBasis-18066|  
e2fb14a393beb5e40519df8cf7ae06b077a398b0
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vbraun):

 * status:  positive_review => needs_work


Comment:

 How about running the tests before setting something to positive review?
 {{{
 sage -t --long src/sage/geometry/linear_expression.py
 **********************************************************************
 File "src/sage/geometry/linear_expression.py", line 183, in
 sage.geometry.linear_expression.LinearExpression.monomial_coefficients
 Failed example:
     sorted(linear.monomial_coefficients().items()
 Exception raised:
     Traceback (most recent call last):
       File "/mnt/disk/home/buildslave-
 sage/slave/sage_git/build/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 496, in _run
         self.compile_and_execute(example, compiler, test.globs)
       File "/mnt/disk/home/buildslave-
 sage/slave/sage_git/build/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 856, in compile_and_execute
         compiled = compiler(example)
       File "/mnt/disk/home/buildslave-
 sage/slave/sage_git/build/local/lib/python2.7/site-
 packages/sage/doctest/forker.py", line 494, in <lambda>
         example.source, filename, "single", compileflags, 1)
       File "<doctest
 sage.geometry.linear_expression.LinearExpression.monomial_coefficients[3]>",
 line 1
         sorted(linear.monomial_coefficients().items()
                                                     ^
     SyntaxError: unexpected EOF while parsing
 **********************************************************************
 1 item had failures:
    1 of   5 in
 sage.geometry.linear_expression.LinearExpression.monomial_coefficients
     [165 tests, 1 failure, 1.47 s]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18066#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to