#19016: Better hash for Element
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: defect | Status: needs_info
Priority: critical | Milestone: sage-6.10
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Nils Bruin, | Reviewers: Volker Braun
Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: public/19016-bis | 81012bc59c29eea8162bcec1ecc21cafa9d1d826
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:116 nbruin]:
> Replying to [comment:114 vbraun]:
> > How about you try to reproduce it with said ticket, if you can get a
new branch by tomorrow I can merge it.
> >
> > Can you also fix the random failure at #19488
>
> The doctest gets introduced on this ticket and it's a bad one: it's just
comparing the parents, so the result is fundamentally ill-defined. Just
delete the test (or check that it's not an error if you care about that
behaviour. I'd say `cmp(b,1)` ''should'' yield an error).
I agree with Nils that an error would be more appropriate. Though, for the
sake of that ticket I would be inclined to follow the default comparison
code from `Element` (in `sage.structure.element`) that is similar to
Python one and compare by `id`. It is also random though.
--
Ticket URL: <http://trac.sagemath.org/ticket/19016#comment:117>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
