#19492: Cleaning linear codes: __eq__, dual_code and commented debug lines
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/clean_linear_code         |  d64c3603f5f870f4d35cfd85ce74c01c5fd6a4f9
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'David Lucas', 'oldvalue': ''}):

 * status:  new => needs_review
 * commit:   => d64c3603f5f870f4d35cfd85ce74c01c5fd6a4f9
 * author:   => David Lucas


Comment:

 Let `C` be a linear code with `H` a parity check matrix of `C`. The
 generator matrix of `C`'s dual is `H`. I made changes in
 `AbstractLinearCode`'s `dual_code` method to use that property instead of
 the old implementation and got something faster.

 I also rewrote `AbstractLinearCode`'s `__eq__` which is now less heavy and
 a bit faster.

 Finally, I removed a lot of old debug prints that were still present in
 this file as commented lines.

 This is now ready for review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=eba939b4bc66092f256d61ff137b6dae39d13508
 eba939b]||{{{Changes in dual_code method}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d64c3603f5f870f4d35cfd85ce74c01c5fd6a4f9
 d64c360]||{{{Changes in __eq__ method, removed commented debug lines}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19492#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to