#6776: [with patch, positive review] plot3d improvement for lattice polytopes
-------------------------+--------------------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.2
Component: geometry | Keywords:
Reviewer: | Author:
Merged: |
-------------------------+--------------------------------------------------
Comment(by mhampton):
Looks good, passes tests and coverage. I did notice that the code for
vertices for 1-D polytopes is broken in plot3d. I.e., the line:
{{{
vertices = [vector(ZZ, list(self.vertex(i))+[0]*(3-dim)) for i in
range(self.nvertices())]
}}}
raises an error, but it isn't the fault of this code. It turns out that
line3d can modify the type of its arguments, which is a totally separate
bug which I will make a new ticket for. So I think that issue is OK for
this patch, it should get resolved separately.
I do have one comment about the vertex labels - if the vertex is at the
barycenter, then it isn't shifted at all and the label is right on top of
the vertex point. Since its not directly addressed by this patch I don't
think that should affect this review though.
Also, someday soon the polytope code should be unified (i.e. in
polyhedra.py and lattice_polytope.py) and refactored. There are so many
functions in both that depend on dimension I think it does make sense to
have a polytope-factory class with dimension-specific subclasses. But
that will be a relatively big job and it will be almost impossible not to
break backward compatibility.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6776#comment:1>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
