#19520: implement random triangulations in a bijective way
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  chapoton               |       Status:  needs_review
           Type:         |    Milestone:  sage-6.10
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  Nathann Cohen
  theory                 |  Work issues:
       Keywords:         |       Commit:
  random graph           |  3a7356b7b4b667ebdaa8f955452e7c8aaefa283c
        Authors:         |     Stopgaps:
  Frédéric Chapoton      |
Report Upstream:  N/A    |
         Branch:         |
  public/19520           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by ncohen):

 Hello Frédéric,

 My last comment was written with 'if' everywhere, because I was not sure
 of what you were doing exactly by looking at the code. Hence, my message
 was both a request for a confirmation that I understood correctly what you
 were doing, and a proposal to rewrite the code in a more readable way.

 I had totally missed the constraint that those merging operations had to
 be made cyclically, for instance. And right now, though I have 'some idea'
 of what you try to do in the code, I still do not understand it.

 My proposition was not mainly a proposition to rewrite it more efficiently
 (and the 'string' of index version does have the 'copy' drawback I
 mentionned) but to rewrite it more clearly.

 Tomorrow I will have a long bus trip, and I can try to rewrite a cyclic
 merging algorithm using 'index' that will only work on a string, leaving
 you to fill it with whatever it does at the same time with the graph.

 At the moment I do not understand what your code does, and I try to do
 what I can to understand it and make life easier for whoever next will
 read it.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19520#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to