#19508: Implementing RijndaelGF
-------------------------------------+-------------------------------------
Reporter: tgagne | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: cryptography | Resolution:
Keywords: cryptography, | Merged in:
aes, rijndaelgf | Reviewers: Martin Albrecht
Authors: Thomas Gagne | Work issues:
Report Upstream: N/A | Commit:
Branch: u/tgagne | d59cee6da4172e3903cd045b54ac29e471e81ca1
/rijndael-gf | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tgagne):
* status: needs_work => needs_review
Comment:
Replying to [comment:19 rbeezer]:
> Replying to [comment:16 jdemeyer]:
> > Replying to [comment:15 tgagne]:
> > > This fixed the problem with building documentation for me, but I did
have to do a `make doc` for it to work since the documentation was
partially built for me.
> > I have no idea what you mean: it's obvious that you need to run `make
doc` (or simply `make`) to build the documentation, it doesn't magically
build by itself.
>
> No, of course the documentation does not build by itself, and Thomas
knows that. But `sage -docbuild reference html` (or similar) is what I
tend to use first. So I think Thomas is trying to help the reviewer by
saying the change was big enough that the `make doc` command is the
**necessary** command and other alternatives will not be successful.
Couldn't have said this better myself.
After moving the class to a different directory I mistakenly didn't
rigorously check that the documentation built in a clean environment and
so the documentation still appeared to work for me with `sage -docbuild
reference/cryptography html`. After making the fix the files from the
failed docbuilds were still causing minor errors with normal docbuilding
which was why I recommended a forceful rebuild of everything with `make
doc`.
I've done more testing on getting the documentation to build in a clean
environment and I'm confident that the fix I pushed earlier makes it build
properly.
Also:
Replying to [comment:16 jdemeyer]:
> One more detail: could you use the standard copyright template from
http://doc.sagemath.org/html/en/developer/coding_basics.html#headings-of-
sage-library-code-files
Thanks for pointing this out! It's easy to let little things like this
slip by.
--
Ticket URL: <http://trac.sagemath.org/ticket/19508#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
