#19545: Mathon's pseudocylic strongly regular graphs.
-------------------------+-------------------------------------------------
Reporter: | Owner:
dimpase | Status: needs_info
Type: | Milestone: sage-6.10
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: Dima | 7da82db694e3b8c0467526ee5cc7141d40604dd6
Pasechnik | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dimpase/matpc |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: new => needs_info
Comment:
Helloooooooooooooooo Dima,
Thank you for this strongly regular graph. Here is a first-pass review:
- The `G` parameter scared me a bit, but it seems that you don't use it at
all. Same for `L`. Could you remove them?
- That's one useless lambda function `:-P`
{{{
#!diff
-return (lambda q : MathonPseudocyclicStronglyRegularGraph(q),t)
+return (MathonPseudocyclicStronglyRegularGraph,t)
}}}
- (not important) you split 'import' blocks when they are longer than 80
characters. I believe that in those cases the code is more readable if
you
leave it on it line.
{{{
+ from sage.matrix.constructor import matrix, block_matrix, \
+ ones_matrix, identity_matrix
}}}
If it were me I wouldn't have split this one. Just a remark, it's up to
you.
- I don't think that you need to import `ValueError` (or any of the common
Python exceptions). It's always around.
- Misleading index:
{{{
+ # Order the elements of K in K_list
+ # so that K_list[i] = -K_list[n-i-1], and 0 comes last
}}}
`n-i-2`?
- You really don't find the latter more legible?...
{{{
P = map(lambda b: matrix(ZZ,q,q,lambda i,j: 1 if a[j]==a[i]+b else 0),
a)
P = [matrix(ZZ,q,q,lambda i,j: 1 if a[j]==a[i]+b else 0)
for b in a]
}}}
- There is a missing ')' in your TODO block.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19545#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
