#19296: Generating function in FindStat interface
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.10
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  FindStat, OEIS     |    Reviewers:  Martin Rubey,
        Authors:  Christian Stump,   |  Christian Stump
  Martin Rubey                       |  Work issues:  document
Report Upstream:  N/A                |       Commit:
         Branch:                     |  1c83fe3962b1ef7dd698b7e1bab86561473d9d27
  u/mantepse/generating_function_in_findstat_interface|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  positive_review => needs_work


Comment:

 This is silly:
 {{{
 try:
     assert foo
 except AssertionError:
     raise ValueError(...)
 }}}

 it would be much better to write this is
 {{{
 if not foo:
     raise ValueError(...)
 }}}
 but really, I think you also want to catch `TypeError` from the `depth =
 int(depth)` call.

 You should also add doctests for these bad inputs.

--
Ticket URL: <http://trac.sagemath.org/ticket/19296#comment:106>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to