#2624: [with patch, needs review] parallel testing: sage -tp foo/bar/file.py
should assume 1 thread
---------------------------+------------------------------------------------
 Reporter:  mabshoff       |        Owner:  jhpalmieri
     Type:  enhancement    |       Status:  assigned  
 Priority:  major          |    Milestone:  sage-4.1.2
Component:  doctest        |   Resolution:            
 Keywords:                 |     Reviewer:            
   Author:  John Palmieri  |       Merged:            
---------------------------+------------------------------------------------

Comment(by ddrake):

 Oops, there's a typo: {{{numthreads = min(numthreads, len(files))}}}
 should be *after* {{{files}}} is populated; otherwise, a directory with
 tons of files counts as one file! If you move that bit to line 324 (after
 the {{{populatefilelist(infiles)}}} stanza), everything works as expected.
 With that change, I give this patch a positive review. John, after
 updating your patch, you can change the title to positive review.

 '''Release manager''': please check the files {{{COPYING.txt}}},
 {{{install}}}, and {{{spkg-install}}} into the sage_scripts hg repo! Right
 now they're not tracked at all.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2624#comment:10>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to