#19603: Quotient of incompatible lattices
-------------------------------------+-------------------------------------
Reporter: mjo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Andrey | Reviewers: Michael Orlitzky
Novoseltsev | Work issues:
Report Upstream: N/A | Commit:
Branch: | d762db73f002033ef9a1d79776f169f1e11dece6
u/mjo/ticket/19603 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by mjo):
* commit: 5858c6875286e2fc5de79d28d8def468008f025b =>
d762db73f002033ef9a1d79776f169f1e11dece6
* branch: u/novoselt/ticket/19603 => u/mjo/ticket/19603
Comment:
That's OK, I didn't have my hopes up for the error message.
My other concern was basically that this branch looked unreachable,
{{{
try:
W = V.submodule(W)
except (TypeError, ArithmeticError):
raise ArithmeticError("W must be a sublattice of V")
}}}
because the error that gets thrown in `submodule()` is a `ValueError`. But
I see that I was wrong, and I added the doctest once I figured out how to
cause that `ArithmeticError`.
Positive review otherwise.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=399bc7383ab3ac9edbffd4f21f5dd9cb3fd9b86c
399bc73]||{{{Improve checks for toric lattice span and quotient.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5f62fd8c978aa67c8de7c554dda4aa1d7644fed9
5f62fd8]||{{{Trac #19603: remove trailing whitespace (review).}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3c1cb53843a3582a6dc5808c89c81bb30011c960
3c1cb53]||{{{Trac #19603: add a few more examples and tests for lattice
quotients (review).}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5858c6875286e2fc5de79d28d8def468008f025b
5858c68]||{{{Typo in doc formatting.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d762db73f002033ef9a1d79776f169f1e11dece6
d762db7]||{{{Trac #19603: test the error branch of ToricLattice_quotient
(review).}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19603#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
