#19196: LatticePoset: add is_dismantlable()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.10
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo, | Reviewers: Frédéric Chapoton,
Frédéric Chapoton | Jori Mäntysalo
Report Upstream: N/A | Work issues:
Branch: public/19196 | Commit:
Dependencies: | 6ac2e219b653b380468205fff51a43a6c168dda4
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Jori M\xe4ntysalo, Fr\xe9d\xe9ric Chapoton',
'oldvalue': u'Jori M\xe4ntysalo'}):
* status: needs_review => positive_review
* reviewer: => Frédéric Chapoton, Jori Mäntysalo
* author: Jori Mäntysalo => Jori Mäntysalo, Frédéric Chapoton
Comment:
Replying to [comment:14 chapoton]:
> ok, good to go. I have put the code into pep8 standard.
>
> If you approve my small changes, you can set to positive review.
I did, and also put your name to reviewer field.
> By the way, please avoid the final underscores in your branch names, as
it makes rather hard to copy/paste. Better to keep the branch names short
and simple, I would say.
That this was generated name from `git trac`, I guess. I will try to use
better names from now on. And maybe some day I will remember to use PEP 8
standard...
Thanks - for this, and for many other reviews.
--
Ticket URL: <http://trac.sagemath.org/ticket/19196#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
