#18945: Game Theory: Build class for extensive form games
-------------------------------------+-------------------------------------
       Reporter:  hhlorrimore        |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  game theory        |   Resolution:
       Keywords:  Game Theory,       |    Merged in:
  Extensive Form Games               |    Reviewers:
        Authors:  Hannah Lorrimore,  |  Work issues:
  Vincent Knight                     |       Commit:
Report Upstream:  N/A                |  98f75571975d46eada81f091ac649dd849d487de
         Branch:                     |     Stopgaps:
  u/hhlorrimore/extensiveform        |
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by ptigwe):

 Just a few observations from looking at the initialization methods:

  * Would it be possible to automatically name the players, in a similar
 manner that the nodes are automatically named if no name is given.
  * The function "_player_check" needs a test for the case where a player
 is correctly passed as a parameter
  * It might be better if the '_player_check' function was called when the
 node is created rather than when multiple nodes have been created. This
 way you can easily tell which node caused the error.
  * Test the structure of the graph generated in '_grow_tree_dictionary'
  * Indicate in the documentation that the current implementation doesn't
 support chance (nature) nodes. And possibly catch the error generated when
 trying to convert a gambit game with a chance node. For example,
 
(https://github.com/gambitproject/gambit/blob/0860191f942fb81f296232b2064456806ed1341c/contrib/games/bayes1a.efg)

 {{{
 ExtensiveFormGame(gambit.Game.read_game("bayes1a.efg"))
 }}}
 yields
 {{{
 KeyError: <Player [CHANCE] in game 'General Bayes game, one stage'>
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18945#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to