#17659: make symbolic series subclass of Expression
-------------------------+-------------------------------------------------
Reporter: rws | Owner:
Type: | Status: needs_work
enhancement | Milestone: sage-6.10
Priority: major | Resolution:
Component: | Merged in:
symbolics | Reviewers: Vincent Delecroix
Keywords: | Work issues:
Authors: Ralf | Commit:
Stephan | 5e2a136fb4fb81f7f17c06b1b037de19159f462d
Report Upstream: N/A | Stopgaps:
Branch: |
public/17659 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* reviewer: => Vincent Delecroix
* milestone: sage-6.8 => sage-6.10
Comment:
Hello,
The ticket looks good.
1. Why do you need all these include
{{{
include "sage/ext/interrupt.pxi"
include "sage/ext/stdsage.pxi"
include "sage/ext/cdefs.pxi"
include "sage/ext/python.pxi"
}}}
As far as I saw you are using none of them.
2. You should fix your mind
{{{
... about 0, about `1` ...
}}}
Either {{{`0`}}} and {{{`1`}}} or {{{0}}} and {{{1}}}.
3. In the example, instead of `float(expr)` could you use
`numerical_approx(expr)`?
4. You should not put `self` as an argument of a method (you did it in
`truncate`). Moreover, it is better to avoid `self` in the documentation.
Always prefer `this expression` or `this object`.
5. In `coefficients`, the argument `sparse` is not documented in the
`INPUT` section
6. In `coefficients`, you should replace `if sparse is True` by `if
sparse`.
--
Ticket URL: <http://trac.sagemath.org/ticket/17659#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
