#19107: Do not count 4 times the same solution (up to rotations) in
QuantuminoSolver
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  slabbe                 |       Status:  needs_info
           Type:         |    Milestone:  sage-6.10
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Vincent Delecroix
  combinatorics          |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  a1d44650afb5b9e0d9bb96f75b6641a3a1a5ce4d
  Sébastien Labbé        |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/slabbe/19107         |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => needs_info
 * milestone:  sage-6.9 => sage-6.10


Comment:

 minor comment: The names `XYZ_iterator` is a bit heavy. With Python 3 more
 stuff is actually returning iterator (like `range`, `zip`) without
 explicit names. What about `isometric_copies` and `translated_copies`. In
 that case `canonical_isometric_copies` would better returns an iterator as
 well.

 otherwise it looks good to me.

--
Ticket URL: <http://trac.sagemath.org/ticket/19107#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to