#16929: Creating SDP interface
-------------------------------------+-------------------------------------
Reporter: ingolfured | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: interfaces | Resolution:
Keywords: | Merged in:
Authors: Dima Pasechnik, | Reviewers:
Ingólfur Eðvarðsson | Work issues:
Report Upstream: N/A | Commit:
Branch: u/dimpase/16929 | c97411d433efa0d09db996ddc475e9b7bf044dd6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
I know you said it's not ready for review, but some obvious things:
1. In `/src/module_list.py`, I doubt you need `include_dirs`.
2. In `/src/module_list.py`, I doubt you need `libraries=["stdc++"]` (is
there any C++ code involved?)
3. In `/src/module_list.py`, add the new modules in the alphabetically
correct place.
4. Use the standard copyright template from
[http://doc.sagemath.org/html/en/developer/coding_basics.html#headings-of-
sage-library-code-files]
5. Adding deprecations to newly-added code makes no sense.
6. Don't `raise Exception(...)`, use a more specific exception class such
as `TypeError`, `ValueError` or `ArithmeticError`.
7. Use `print()` statements compatible with Python 3.
8. Try to avoid `include "sage/ext/cdefs.pxi"`, just `cimport` whatever
you need.
9. Use indentation with multiples of 4 spaces (this isn't the case in
`cpdef int number_of_constraints(self):`)
--
Ticket URL: <http://trac.sagemath.org/ticket/16929#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
