#19552: images and preimages for projective subscheme
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.10
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: subscheme | Reviewers: Vincent Delecroix
iteration | Work issues:
Authors: Ben Hutz | Commit:
Report Upstream: N/A | ab4c42daa999e63000fe824f173a0eaa90defef8
Branch: | Stopgaps:
u/bhutz/ticket/19552 |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
`from copy import copy` is not needed anymore in `algebraic_scheme.py`.
There exists a very nice python tool for that
{{{
$ pyflakes src/sage/schemes/generic/algebraic_scheme.py
src/sage/schemes/generic/algebraic_scheme.py:133: 'copy' imported but
unused
src/sage/schemes/generic/algebraic_scheme.py:140: 'is_MPolynomialRing'
imported but unused
src/sage/schemes/generic/algebraic_scheme.py:3238: local variable 'n' is
assigned to but never used
}}}
On the other hand there is still a `copy` in `projective_point.py`.
About my comment about multiplication of methods, the code in
`nth_iteration` is an exact copy paste of a portion of `orbit`...
Another oneliner simplification
{{{
dict = {}
for i in range(codom.dimension_relative()+1):
dict.update({R.gen(i): f[i]})
}}}
can be written as
{{{
dict = {R.gen(i): f[i] for i in range(codom.dimension_relative()+1)}
}}}
I have no real competence to check the mathematical validity of the code.
If you want somebody else to review that part you might ask on sage-devel.
--
Ticket URL: <http://trac.sagemath.org/ticket/19552#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
