#18128: Add a face truncation method to Polyhedron class
-------------------------------------+-------------------------------------
Reporter: jipilab | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.10
Component: geometry | Resolution:
Keywords: face truncation, | Merged in:
polytope | Reviewers: Vincent Delecroix
Authors: Jean-Philippe | Work issues:
Labbé | Commit:
Report Upstream: N/A | b7cbccf5b241f585b8c1715db61ea0939104ec9e
Branch: | Stopgaps:
u/jipilab/ge_truncation |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* reviewer: => Vincent Delecroix
Comment:
Hello,
Why did you changed the default value of the argument `cut_frac`?
The following is by far not enough to understand what the method is doing
{{{
+ - ``linear_coefficients`` -- tuple of integer. Specify the
coefficient
+ of the normal vector of the cutting hyperplane.
}}}
You should add more description in the docstring. (that would help me to
understand what this method is doing)
In your examples you are only showing how combinatorially the method
behave. I guess that the actual added vertices are indeed interesting.
(that would help me to understand what this method is doing (bis))
There is a trailing whitespace after the docstring and many before the
`return`.
You should replace
{{{
if False not in map(lambda x: facet.contains(x) and
not facet.interior_contains(x), face_vertices):
}}}
by
{{{
if any(facet.contains(x) and not facet.interior_contains(x) for x in
face_vertices):
}}}
Also replace
{{{
linear_evaluation.difference(set([B]))
}}}
by
{{{
linear_evaluation.difference(B)
}}}
And add an example where the base ring does change.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18128#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
