#7008: [with patch, positive review] consolidate in plotting all extraction of
variables, ranges, and fast_float setup
---------------------------------+------------------------------------------
 Reporter:  jason                |       Owner:  was        
     Type:  defect               |      Status:  new        
 Priority:  major                |   Milestone:  sage-4.1.2 
Component:  graphics             |    Keywords:             
 Reviewer:  Karl-Dieter Crisman  |      Author:  Jason Grout
   Merged:                       |  
---------------------------------+------------------------------------------
Changes (by kcrisman):

  * reviewer:  => Karl-Dieter Crisman


Comment:

 >
 > I will check into this.  My guess is that any slowdown is in a fixed
 cost, not a marginal cost, so the slowdown should not scale.  Can you
 test, for example, contour plots with varying grid sizes (before/after the
 patch) to see if there is a huge slowdown?

 I  had already done some of this.  After trying some more stuff, it looks
 like it's just not enough to be worthwhile to do anything else - possibly
 a little more than fixed, but not much.  Just thought you might have a
 thought.

 > That said, fast_float uses fast_callable where it can.  So for most
 functions, I am actually using fast_callable underneath things.

 Ah, I didn't know that.  Neat.

 > > Finally, there should be at least one test to demonstrate that
 > > {{{
 > > sage: plot(f, -pi, pi)
 > > }}}
 > > and friends still work in the one-variable case, because there is no
 reason for that to disappear in the name of consistency.  The more
 parentheses, the more confused students get.  But it can be a test, since
 of course we don't have to promote that syntax.
 >
 > Hmmm...did I delete a test doing that?  I didn't mean to.
 >
 Didn't delete, but a couple of ones in graphics_array got changed.  Not a
 big deal, as there are plenty of others in the main docs - I just didn't
 have time to check if those were the only ones earlier today.

 I like the use of "ignore".

 Okay, code checks out, and a bevy of examples don't just pass tests but
 also look like they are supposed to :)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7008#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to