#19698: install_name_tool: changing install names or rpaths can't be redone
(libsingular)
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  88632a35dd41996ab74658d889ecdddf255ff88a
  u/vbraun/install_name_singular     |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by fbissey):

 * status:  needs_review => positive_review


Comment:

 Looks good to me, although I would have added
 `-headerpad_max_install_name` in there. It is very hard to solve #18892 by
 doing anything else but using `CXX` as the linker - it is a valid from
 many 32bits recent install on any distro. It was first reported to me on
 Gentoo a few weeks before it was reported here.

 In a lot of case you don't want to use the linker directly and let the
 compiler do the magic for you.

 Furthermore, if you are going to add `LDFLAGS=-Wl,-rpath=.....` globally
 you don't want to use `ld` as your linker anywhere. `-Wl,` is a compiler
 instruction to pass its argument to `ld`. Anywhere `ld` is used directly
 you'll have to strip `-Wl,` from `LDFLAGS`.

--
Ticket URL: <http://trac.sagemath.org/ticket/19698#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to