#19743: Generic not_equals methods for objects in coding theory library
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.0
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/default_not_equals_for_linear_codes|  
490f739b55e463543aa8aeb9d1b0189fdad9c718
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dlucas):

 * status:  new => needs_review
 * commit:   => 490f739b55e463543aa8aeb9d1b0189fdad9c718


Old description:

> In this ticket, we propose a default implementation of ``__ne__`` methods
> for ``AbstractLinearCode``, ``Encoder`` and ``Decoder`` classes, which
> means one will only need to implement ``__eq__`` in the subclasses.
>
> This new ``__ne__`` simply returns the inverse of the return value of
> ``__eq__``.

New description:

 In this ticket, we propose a default implementation of `__ne__` methods
 for `AbstractLinearCode`, `Encoder` and `Decoder` classes, which means one
 will only need to implement `__eq__` in the subclasses.

 This new `__ne__` simply returns the inverse of the return value of
 `__eq__`.

--

Comment:

 I removed the old implementation of `__ne__` in `grs.py`, created generic
 implementation for the top classes `Decoder`, `Encoder` and
 `AbstractLinearCode` and implemented `__eq__` for encoders in
 `linear_code.py`.

 This is now open for review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=490f739b55e463543aa8aeb9d1b0189fdad9c718
 490f739]||{{{Removed old __ne__ methods, implemented generic __ne__ in
 Decoder, Encoder and AbstractLinearCode}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19743#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to