#19609: Added image and kernel methods to morphisms of finite-dimensional
modules
with basis
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: linear algebra | Resolution:
Keywords: kernel, image, | Merged in:
module morphism | Reviewers:
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | fd8d546eaeeb845b5b610f946ce7ab27e77c4095
public/categories/image_kernel_module_morphism-19609| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by darij):
Hmm, I'm not sure I'm happy with this -- but once again, this seems to be
a Sage design flaw, not an error of your branch. Now that we are
overriding `__eq__`, everyone implementing a new class of module morphism
will have to override `__eq__` as well or risk distinct morphisms
comparing as equal. Maybe we should also compare `on_basis()` and
`_inverse` on triangular module morphisms?
Nicolas, Simon, or whoever else understands these matters: any chance you
could look over the `__eq__` definitions?
The rest of the code LGTMs to me.
--
Ticket URL: <http://trac.sagemath.org/ticket/19609#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
