#19778: McFarland 1973 construction for difference sets
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.0
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  8fe3844f0894a817e8a81f959dae5dfb384bc2ba
  u/vdelecroix/19778                 |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello again,

 I pushed a couple of modifications at `public/19778`. [A typo here/a
 comment there], though I also added a couple of checks in a test, and
 multiplied by (q-1) instead of using `// (q-1)`, just in case the integer
 division may make equal two values which should not be. I also used 'izip'
 in a loop somewhere: you are welcome to revert it if you do not like it,
 and to change the ticket's status when you are satisfied with the code.

 Thanks for this addition! I will not get a look at the ticket above this
 one.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19778#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to