#19795: GAP3 does not have IsIdenticalObject
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: Travis Scrimshaw, | Work issues:
Janoš Vidali | Commit:
Report Upstream: N/A | 8ff1fe8c5e9a3c1a3eaff48c4ef6b38333d5a82d
Branch: | Stopgaps:
public/interfaces/fix_gap3-19795 |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Travis Scrimshaw, Jano\u0161 Vidali', 'oldvalue':
''}):
* status: new => needs_review
* commit: => 8ff1fe8c5e9a3c1a3eaff48c4ef6b38333d5a82d
* branch: => public/interfaces/fix_gap3-19795
* author: => Travis Scrimshaw, Janoš Vidali
Comment:
Replying to [comment:3 jaanos]:
> > - a subclass of the GAP interpreter for backwards compatibility with
GAP3 which just has the one difference in `function_call()`,
>
> There already is a separate class for GAP3 which inherits from
`Gap_generic`.
Good; let us use that.
> The cleanest solution IMO would be to have a method
`_identical_function` in `Gap_generic` (parallel to `_equality_symbol`
etc.), say:
> {{{
> #!python
> def _identical_function(self):
> return "IsIdenticalObj"
> }}}
> and then have it overridden in `Gap3`.
I think it should be a class-level attribute instead of a method because
it speed cost and a method is IMO somewhat overkill (because no work is
done).
Anne, can you check to see if this works?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=8ff1fe8c5e9a3c1a3eaff48c4ef6b38333d5a82d
8ff1fe8]||{{{Adding an identical function class attribute.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19795#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
