#13250: Additional poset examples
-------------------------------------+-------------------------------------
Reporter: csar | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: combinatorics | Resolution:
Keywords: sd40, posets | Merged in:
Authors: Alex Csar, | Reviewers: Jori Mäntysalo
Frédéric Chapoton | Work issues:
Report Upstream: N/A | Commit:
Branch: u/chapoton/13250 | f392c04de7bc3e40090ef78be44b2a85d5893a43
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):
* reviewer: => Jori Mäntysalo
Comment:
This is a good addition. However, some comments:
- Index of `poset_examples.py` is missing functions. Maybe this could be a
place for Nathann's automatic indexing feature.
- `print "TEST FAILED"` -part should be on `TESTS`, not on `EXAMPLES`.
- `SetPartitions` works. However, actually you can say
`Posets.SetPartitions('junk')`, but the documentation mentions only
integers. Safe option is to check input type and raise exception if it is
not an integer; it is always easier to extend than to deprecate.
- `YoungsLattice` is returned as a poset. Not so important, but why not as
a meet-semilattice?
- Similarly, `YoungsLatticePrincipalOrderIdeal` is lattice. And I think
that `PartitionsDominanceOrder` is also.
- Should an input section crosslink to type when the input is of type
`Partition`? See output block in `antichains`. OTOH maybe just a noise.
- `PartitionsDominanceOrder('junk')` gives error but
`PartitionsDominanceOrder(-1)` does not.
- Maybe a stupid question, but is "integer partitions" by definition
sorted partitioning, i.e. not for example `[4,2,3]`? I was just wondering
about doc of `PartitionsDominanceOrder`.
As I don't know Coxeter groups, this needs another reviewer. But I can
check `poset_examples.py`.
--
Ticket URL: <http://trac.sagemath.org/ticket/13250#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
