#19883: Let PARI handle its own stack
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.0
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Jeroen Demeyer     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  34c272719df882e68b04500bcf78452fd198307f
  u/jdemeyer/let_pari_handle_its_own_stack|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by pbruin):

 Two small comments (no time for a complete review):
 - remove mention of the deleted `public_memory_functions.patch` in
 `build/pkgs/pari/patches/README.txt`
 - I think you can remove the following lines from
 `PariInstance.__dealloc__()`:
 {{{
         sage_free(<void*>pari_mainstack.vbot)
         pari_mainstack.rsize = 0
         pari_mainstack.vsize = 0
         pari_mainstack.bot = 0
         pari_mainstack.vbot = 0
         pari_mainstack.top = 0
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/19883#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to