#19901: Index of Permutation Group methods
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-7.0
enhancement | Resolution:
Priority: major | Merged in:
Component: group | Reviewers: Jori Mäntysalo
theory | Work issues:
Keywords: | Commit:
Authors: | 0750c2f8580a84f313d253dd8fd41df0eb2871c9
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/19901 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by jmantysalo):
* status: needs_review => positive_review
* reviewer: => Jori Mäntysalo
Comment:
Seems good, and Sage is better with this than without. Hence set to
positive_review.
However, there are some dollar signs used at docstrings. I have been said
that I should use backstick. As you don't introduce new dollar signs, this
patch can't make things any worse. I don't remember the rationale behind
dollar-backstick -difference.
(Also "computes" and "returns" should be "return", but that's a place for
a new ticket, I think.)
--
Ticket URL: <http://trac.sagemath.org/ticket/19901#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
