#19511: q-ary symmetric channel class for coding theory
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  dlucas                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.10
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:
  coding theory          |  Work issues:
       Keywords:         |       Commit:
        Authors:  David  |  ac23bcc4387e05e1cdd5d8efd832381f59b7738f
  Lucas                  |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/jsrn/qsc             |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by jsrn):

 * commit:  1a2c80fc81eb61d31a7dbee989839c2aae3b5cdc =>
     ac23bcc4387e05e1cdd5d8efd832381f59b7738f


Comment:

 Hi,
 I had a look at the code. It looks fine :-) I clarified some documentation
 wrt. alphabets and spaces, please look at that. I also fixed a bug in the
 while-loop for adding errors.

 Apart from that I have a few questions/requests:
 - Should this channel-intro text really be in the q-ary symmetric channels
 doc?
 - Can you please make a test that input space is of the form Sigma^n, and
 that Sigma has random_element
 - It would be nice with a "probability_of_exactly_t_errors" and a
 "probability_of_at_most_t_errors" method :-) But I don't insist for now,
 the channel is functioning as it is.

 Best,
 Johan
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=ac23bcc4387e05e1cdd5d8efd832381f59b7738f
 ac23bcc]||{{{Fixed a nasty bug. Clarified documentation wrt.
 alphabet.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19511#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to